Skip to content

Improve Tests#520

Draft
jwindgassen wants to merge 1 commit intojupyterhub:mainfrom
jwindgassen:callable-tests
Draft

Improve Tests#520
jwindgassen wants to merge 1 commit intojupyterhub:mainfrom
jwindgassen:callable-tests

Conversation

@jwindgassen
Copy link
Contributor

As requested in #519, I added some additional tests, so that traits that accept a callable (command, environment, mappath, etc.) will be tested accordingly.

I might add more test cases, so let me know of anything else.

Copy link
Member

@manics manics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants

Comments